From d88ade486b405b8c189f13f05262f9c1a86f6e41 Mon Sep 17 00:00:00 2001 From: Anthony Scemama Date: Thu, 3 Jun 2021 01:48:26 +0200 Subject: [PATCH] Clean cppcheck --- Makefile.am | 4 +++- org/qmckl_nucleus.org | 17 +++++++---------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/Makefile.am b/Makefile.am index 110ff8a..57ad20b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -166,7 +166,9 @@ cppcheck: cppcheck.out cppcheck.out: $(qmckl_h) cd src/ && \ cppcheck --addon=cert -q --error-exitcode=0 \ - --enable=all \ + --enable=all --suppress="unusedStructMember"\ + --suppress="unusedFunction" \ + --suppress="missingIncludeSystem" \ --language=c --std=c99 -rp --platform=unix64 \ -I../include *.c *.h 2>../$@ diff --git a/org/qmckl_nucleus.org b/org/qmckl_nucleus.org index 8bd2893..004560f 100644 --- a/org/qmckl_nucleus.org +++ b/org/qmckl_nucleus.org @@ -392,18 +392,15 @@ qmckl_set_nucleus_kappa(qmckl_context context, const double rescale_factor_kappa <> //TODO: Check for small values of kappa - //if (rescale_factor_kappa == 0) { - // return qmckl_failwith( context, - // QMCKL_INVALID_ARG_2, - // "qmckl_set_nucleus_kappa", - // "rescale_factor_kappa cannot be 0"); - //} + if (rescale_factor_kappa <= 0.0) { + return qmckl_failwith( context, + QMCKL_INVALID_ARG_2, + "qmckl_set_nucleus_kappa", + "rescale_factor_kappa cannot be 0"); + } int32_t mask = 1 << 2; - int64_t num; - qmckl_exit_code rc; - ctx->nucleus.rescale_factor_kappa = rescale_factor_kappa; <> @@ -836,7 +833,7 @@ end function qmckl_compute_nn_distance_rescaled_f #+begin_src c :tangle (eval h_private_func) :comments org :exports none qmckl_exit_code qmckl_compute_nn_distance_rescaled ( - const qmckl_context context, + const qmckl_context context, const int64_t nucl_num, const double rescale_factor_kappa, const double* coord,