mirror of
https://github.com/triqs/dft_tools
synced 2024-12-25 13:53:40 +01:00
b534936589
- The previous version of the * operator for matrix was too clever. It was giving a lazy object and then rewriting C = A *B into gemm (a,A,B,0,C). The pb was in case of aliasing : when e.g. C = A, or is a part of A. gemm is not correct that case, and as a result generic code like a = a *b may not be correct in matrix case, which is unacceptable. - So we revert to a simple * operator for matrix that does immediate computation. Same thing for matrix* vector - we also suppress a_x_ty class. -> for M = a * b, when M is a matrix, there is no overhead due to move assignment -> however, when M is a view, there is an additionnal copy. -Correctness comes first, hence the fix. However, if one wants more speed and one can guarantee that there is no aliasing possible, then one has to write a direct gemm call. -> det_manip class was adapted, since in that case, we can show there no alias, and we want the speed gain, so the * ops where replaced by direct blas call (using the array blas interface). -> also gemm, gemv, ger were overloaded in the case the return matrix/vector (i.e. last parameter of the function) is not an lvalue, but a temporary view created on the fly. |
||
|---|---|---|
| .. | ||
| apply_on_tuple_s.cpp | ||
| array1.cpp | ||
| array2.cpp | ||
| array_lazy_assign.cpp | ||
| array_short1.cpp | ||
| array_view.cpp | ||
| clef1.cpp | ||
| clef_common.hpp | ||
| CMakeLists.txt | ||
| gemv.cpp | ||
| gf_s.cpp | ||
| isol_array_foreach_pb.cpp | ||
| matmul_s.cpp | ||
| pool.cpp | ||
| speed_tester.hpp | ||