LCPQ/dft_tools
3
0
Fork 0
mirror of https://github.com/triqs/dft_tools synced 2024-12-24 13:23:37 +01:00
Code Issues Releases Wiki Activity

gf : bug correction in make_block_gf

Browse Source 
- See comment : a move + undefined order of args eval. of function
  error.
This commit is contained in:
Olivier Parcollet 2014-06-23 16:13:27 +02:00
parent 6bacb101bc
commit c8be004055
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
triqs/gfs/block.hpp
View File

@ -103,7 +103,8 @@ namespace gfs {
// from a vector of gf (moving directly)
template <typename Variable, typename Target, typename Opt>
block_gf<Variable, Target, Opt> make_block_gf(std::vector<gf<Variable, Target, Opt>> V) {
return {{int(V.size())}, std::move(V), nothing{}, nothing{}, nothing{}};
int s = V.size(); // DO NOT use V.size in next statement, the V is moved and the order of arg. evaluation is undefined.
return {{s}, std::move(V), nothing{}, nothing{}, nothing{}};
}
// from a vector of gf : generalized to have a different type of gf in the vector (e.g. views...)
@ -154,7 +155,8 @@ namespace gfs {
}
template <typename GF> gf_view<block_index, typename GF::regular_type> make_block_gf_view_from_vector(std::vector<GF> V) {
return {{int(V.size())}, std::move(V), nothing{}, nothing{}, nothing{}};
int s = V.size();
return {{s}, std::move(V), nothing{}, nothing{}, nothing{}};
}
template <typename GF>